85 lines
3.5 KiB
Diff
85 lines
3.5 KiB
Diff
From 53ed3dbd9c05805eb431de81a19712099a099db9 Mon Sep 17 00:00:00 2001
|
|
From: amcamd <andrew.chapman@gmail.com>
|
|
Date: Mon, 29 Apr 2024 15:06:12 -0500
|
|
Subject: [PATCH] remove mf16c flag as f16 intrinsics _cvtss_sh, _cvtsh_ss no
|
|
longer used
|
|
|
|
---
|
|
clients/benchmarks/CMakeLists.txt | 8 --------
|
|
clients/gtest/CMakeLists.txt | 4 ----
|
|
clients/samples/CMakeLists.txt | 2 --
|
|
library/CMakeLists.txt | 5 +----
|
|
4 files changed, 1 insertion(+), 18 deletions(-)
|
|
|
|
diff --git a/clients/benchmarks/CMakeLists.txt b/clients/benchmarks/CMakeLists.txt
|
|
index 0bfd30af..e953a974 100644
|
|
--- a/clients/benchmarks/CMakeLists.txt
|
|
+++ b/clients/benchmarks/CMakeLists.txt
|
|
@@ -97,14 +97,6 @@ if( BUILD_WITH_TENSILE )
|
|
target_link_libraries( rocblas-gemm-tune PRIVATE ${COMMON_LINK_LIBS} )
|
|
endif()
|
|
|
|
-if( CMAKE_COMPILER_IS_GNUCXX OR CMAKE_CXX_COMPILER_ID MATCHES "Clang")
|
|
- # GCC or hip-clang needs specific flags to turn on f16c intrinsics
|
|
- target_compile_options( rocblas-bench PRIVATE -mf16c )
|
|
- if( BUILD_WITH_TENSILE )
|
|
- target_compile_options( rocblas-gemm-tune PRIVATE -mf16c )
|
|
- endif()
|
|
-endif()
|
|
-
|
|
target_compile_options(rocblas-bench PRIVATE $<$<COMPILE_LANGUAGE:CXX>:${COMMON_CXX_OPTIONS}>)
|
|
if( BUILD_WITH_TENSILE )
|
|
target_compile_options(rocblas-gemm-tune PRIVATE $<$<COMPILE_LANGUAGE:CXX>:${COMMON_CXX_OPTIONS}>)
|
|
diff --git a/clients/gtest/CMakeLists.txt b/clients/gtest/CMakeLists.txt
|
|
index 8352276c..3a3f003c 100644
|
|
--- a/clients/gtest/CMakeLists.txt
|
|
+++ b/clients/gtest/CMakeLists.txt
|
|
@@ -165,10 +165,6 @@ else()
|
|
endif()
|
|
target_link_libraries( rocblas-test PRIVATE ${COMMON_LINK_LIBS} )
|
|
|
|
-if( CMAKE_COMPILER_IS_GNUCXX OR CMAKE_CXX_COMPILER_ID MATCHES "Clang")
|
|
- # GCC or hip-clang needs specific flag to turn on f16c intrinsics
|
|
- target_compile_options( rocblas-test PRIVATE -mf16c )
|
|
-endif( )
|
|
target_compile_options(rocblas-test PRIVATE $<$<COMPILE_LANGUAGE:CXX>:${COMMON_CXX_OPTIONS}>)
|
|
|
|
target_compile_definitions( rocblas-test PRIVATE ROCM_USE_FLOAT16 ROCBLAS_INTERNAL_API ROCBLAS_NO_DEPRECATED_WARNINGS )
|
|
diff --git a/clients/samples/CMakeLists.txt b/clients/samples/CMakeLists.txt
|
|
index 2f6caeaf..8d09dc97 100644
|
|
--- a/clients/samples/CMakeLists.txt
|
|
+++ b/clients/samples/CMakeLists.txt
|
|
@@ -115,8 +115,6 @@ foreach( exe ${sample_list_all} )
|
|
)
|
|
|
|
if( CMAKE_COMPILER_IS_GNUCXX OR CMAKE_CXX_COMPILER_ID MATCHES "Clang")
|
|
- # GCC or hip-clang needs specific flags to turn on f16c intrinsics
|
|
- target_compile_options( ${exe} PRIVATE -mf16c )
|
|
target_compile_definitions( ${exe} PRIVATE ROCBLAS_INTERNAL_API )
|
|
endif( )
|
|
|
|
diff --git a/library/CMakeLists.txt b/library/CMakeLists.txt
|
|
index 90a75dd3..9a5717ba 100755
|
|
--- a/library/CMakeLists.txt
|
|
+++ b/library/CMakeLists.txt
|
|
@@ -1,5 +1,5 @@
|
|
# ########################################################################
|
|
-# Copyright (C) 2016-2023 Advanced Micro Devices, Inc. All rights reserved.
|
|
+# Copyright (C) 2016-2024 Advanced Micro Devices, Inc. All rights reserved.
|
|
#
|
|
# Permission is hereby granted, free of charge, to any person obtaining a copy
|
|
# of this software and associated documentation files (the "Software"), to deal
|
|
@@ -60,9 +60,6 @@ function( rocblas_library_settings lib_target_ )
|
|
$<INSTALL_INTERFACE:${CMAKE_INSTALL_INCLUDEDIR}>
|
|
)
|
|
|
|
- # GCC or hip-clang needs specific flags to turn on f16c intrinsics
|
|
- target_compile_options( ${lib_target_} PRIVATE -mf16c )
|
|
-
|
|
# Do not allow Variable Length Arrays (use unique_ptr instead)
|
|
target_compile_options( ${lib_target_} PRIVATE -Werror=vla )
|
|
|
|
--
|
|
2.47.0
|
|
|