63 lines
2.9 KiB
Diff
63 lines
2.9 KiB
Diff
From 30e1d5e22213fdaca2a29ec3400c927d710a37a8 Mon Sep 17 00:00:00 2001
|
|
From: Thomas Devoogdt <thomas.devoogdt@barco.com>
|
|
Date: Mon, 16 Jan 2023 17:03:30 +0100
|
|
Subject: [PATCH] REGRESSION(257865@main): B3Validate.cpp: fix
|
|
!ENABLE(WEBASSEMBLY_B3JIT)
|
|
|
|
https://bugs.webkit.org/show_bug.cgi?id=250681
|
|
|
|
Reviewed by NOBODY (OOPS!).
|
|
|
|
WasmTypeDefinition.h isn't included if not ENABLE(WEBASSEMBLY_B3JIT).
|
|
Also, toB3Type and simdScalarType are not defined if it is included.
|
|
|
|
Signed-off-by: Thomas Devoogdt <thomas.devoogdt@barco.com>
|
|
---
|
|
Source/JavaScriptCore/b3/B3Validate.cpp | 12 +++++++++---
|
|
1 file changed, 9 insertions(+), 3 deletions(-)
|
|
|
|
diff --git a/Source/JavaScriptCore/b3/B3Validate.cpp b/Source/JavaScriptCore/b3/B3Validate.cpp
|
|
index d06a76023392a..53bf8b16ed869 100644
|
|
--- a/Source/JavaScriptCore/b3/B3Validate.cpp
|
|
+++ b/Source/JavaScriptCore/b3/B3Validate.cpp
|
|
@@ -47,6 +47,12 @@
|
|
#include <wtf/StringPrintStream.h>
|
|
#include <wtf/text/CString.h>
|
|
|
|
+#if ENABLE(WEBASSEMBLY) && ENABLE(WEBASSEMBLY_B3JIT)
|
|
+#define simdScalarTypeToB3Type(type) toB3Type(Wasm::simdScalarType(type))
|
|
+#else
|
|
+#define simdScalarTypeToB3Type(type) B3::Type()
|
|
+#endif
|
|
+
|
|
namespace JSC { namespace B3 {
|
|
|
|
namespace {
|
|
@@ -452,7 +458,7 @@ class Validater {
|
|
case VectorExtractLane:
|
|
VALIDATE(!value->kind().hasExtraBits(), ("At ", *value));
|
|
VALIDATE(value->numChildren() == 1, ("At ", *value));
|
|
- VALIDATE(value->type() == toB3Type(Wasm::simdScalarType(value->asSIMDValue()->simdLane())), ("At ", *value));
|
|
+ VALIDATE(value->type() == simdScalarTypeToB3Type(value->asSIMDValue()->simdLane()), ("At ", *value));
|
|
VALIDATE(value->child(0)->type() == V128, ("At ", *value));
|
|
break;
|
|
case VectorReplaceLane:
|
|
@@ -460,7 +466,7 @@ class Validater {
|
|
VALIDATE(value->numChildren() == 2, ("At ", *value));
|
|
VALIDATE(value->type() == V128, ("At ", *value));
|
|
VALIDATE(value->child(0)->type() == V128, ("At ", *value));
|
|
- VALIDATE(value->child(1)->type() == toB3Type(Wasm::simdScalarType(value->asSIMDValue()->simdLane())), ("At ", *value));
|
|
+ VALIDATE(value->child(1)->type() == simdScalarTypeToB3Type(value->asSIMDValue()->simdLane()), ("At ", *value));
|
|
break;
|
|
case VectorNot:
|
|
case VectorAbs:
|
|
@@ -475,7 +481,7 @@ class Validater {
|
|
VALIDATE(!value->kind().hasExtraBits(), ("At ", *value));
|
|
VALIDATE(value->numChildren() == 1, ("At ", *value));
|
|
VALIDATE(value->type() == V128, ("At ", *value));
|
|
- VALIDATE(value->child(0)->type() == toB3Type(Wasm::simdScalarType(value->asSIMDValue()->simdLane())), ("At ", *value));
|
|
+ VALIDATE(value->child(0)->type() == simdScalarTypeToB3Type(value->asSIMDValue()->simdLane()), ("At ", *value));
|
|
break;
|
|
|
|
case VectorPopcnt:
|